auth packet cache ignores EDNS presence #630

Closed
Habbie opened this Issue Apr 26, 2013 · 2 comments

Projects

None yet

1 participant

@Habbie
Member
Habbie commented Apr 26, 2013

The authoritative packet cache does not check whether a cached packet and the response is it being matched again, have the same EDNS status (present vs. not-present).

Because it does take max reply length into account, the impact of this is limited - non-EDNS clients would only get EDNS replies from the cache if the EDNS bufsize happened to be 512.

We need to either take EDNS into account in the cache, or revert r2649.

@Habbie Habbie was assigned Apr 26, 2013
@Habbie Habbie closed this Apr 26, 2013
@Habbie Habbie added a commit that referenced this issue Apr 26, 2013
@Habbie Habbie auth packetcache now honours edns presence as a variable. Found while…
… investigating a report from Winfried Angele. Patch by Ruben d'Arco. Includes test. Closes #630

git-svn-id: svn://svn.powerdns.com/pdns/trunk/pdns@2982 d19b8d6e-7fed-0310-83ef-9ca221ded41b
17d0b1e
@Habbie
Member
Habbie commented Apr 26, 2013

Author: anon
Hi,

A patch for this:
https://github.com/cyclops1982/powerdns/compare/master...630.diff

Bert had some questions related to the recursor using the same PacketCache. I'm not completely sure if this has impact, but i couldn't find a relation between this PacketCache and the recursor.

@Habbie
Member
Habbie commented Apr 26, 2013

Author: peter
applied in r2982, with test. Thanks!

@mind04 mind04 pushed a commit to mind04/pdns that referenced this issue Apr 26, 2013
peter auth packetcache now honours edns presence as a variable. Found while…
… investigating a report from Winfried Angele. Patch by Ruben d'Arco. Includes test. Closes #630

git-svn-id: svn://svn.powerdns.com/pdns/trunk/pdns@2982 d19b8d6e-7fed-0310-83ef-9ca221ded41b
45bf3e9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment