New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

botan 2.5.0 deprecated CurveGFp #6474

Closed
rgacogne opened this Issue Apr 12, 2018 · 0 comments

Comments

Projects
None yet
1 participant
@rgacogne
Member

rgacogne commented Apr 12, 2018

Short description

We should look into it and find out what is the current recommend way:

botansigners.cc: In member function ‘virtual void GOSTDNSCryptoKeyEngine::fromPublicKeyString(const string&)’:
botansigners.cc:173:35: warning: ‘const Botan::CurveGFp& Botan::EC_Group::get_curve() const’ is deprecated: Avoid CurveGFp [-Wdeprecated-declarations]
   PointGFp point(params.get_curve(), x,y);
                                   ^
In file included from /usr/include/botan-2/botan/ecc_key.h:13:0,
                 from /usr/include/botan-2/botan/gost_3410.h:13,
                 from botansigners.cc:26:
/usr/include/botan-2/botan/ec_group.h:127:58: note: declared here
       BOTAN_DEPRECATED("Avoid CurveGFp") const CurveGFp& get_curve() const;

Deprecated in this commit: randombit/botan@e5b9ee2

The current documentation states:

There should not be any reason for applications to use this type. If you need EC primitives use the interfaces EC_Group and PointGFp
It is likely this class will be removed entirely in a future major release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment