New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dnsdist: webserver should set Connection: close in standard headers #6532

Closed
DrewBloechl opened this Issue Apr 25, 2018 · 0 comments

Comments

Projects
None yet
2 participants
@DrewBloechl

DrewBloechl commented Apr 25, 2018

  • Program: dnsdist
  • Issue type: Bug report

Short description

The dnsdist webserver seems to close connections after each request without signaling to the client that it's going to do so with a Connection: close header. This introduces a race condition where an HTTP/1.1 client that implements connection reuse may try to send a second request over the connection if it doesn't receive the TCP FIN in time, and this second request will get hung up on.

Specifying {["Connection"]="close"} in webserver()'s custom headers seems to work around the problem.

Environment

  • Operating system: Debian buster (aka "testing" as of right now)
  • Software version: 1.3.0
  • Software source: Debian repo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment