Patch: Fix nonblocking on receivers #664

Closed
Habbie opened this Issue Apr 26, 2013 · 3 comments

Projects

None yet

1 participant

@Habbie
Member
Habbie commented Apr 26, 2013

Two issues:

  1. nonblocking is not set on udp6 sockets
  2. udp4 tests to see if there is only 1 socket and then sets nonblocking, however if you have a udp4 and udp6 socket then it won't be set to nonblocking

Mark

@Habbie Habbie was assigned Apr 26, 2013
@Habbie
Member
Habbie commented Apr 26, 2013

Attachment '' (pdns-nonblocking.patch) https://gist.github.com/5466851

@Habbie
Member
Habbie commented Apr 26, 2013

Attachment '' (pdns-3.2-ipv6-nonblocking.patch) https://gist.github.com/5466852

@Habbie
Member
Habbie commented Apr 26, 2013

Author: anon
This patch is actually buggy - if there is only 1 ip specified then ::receiver will go into a loop because you specialcase that to use recvmsg which will return straight away. The attached patch also removes this special case.

@ahupowerdns ahupowerdns added a commit that referenced this issue May 23, 2013
@ahupowerdns ahupowerdns Merge updated patch found in #664, which fixes #664 by removing the o…
…ptimization of not using 'poll' when we are listening on only 1 socket. This will slow us down when listening to one socket only,

but hopefully only slightly. It does simplify the code.
315dd2e
@ahupowerdns ahupowerdns added a commit that closed this issue May 23, 2013
@ahupowerdns ahupowerdns Merge updated patch found in #664, which fixes #664 by removing the o…
…ptimization of not using 'poll' when we are listening on only 1 socket. This will slow us down when listening to one socket only,

but hopefully only slightly. It does simplify the code.
315dd2e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment