New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ALIAS RR type still broken if querying over TCP #6654

Closed
klaus3000 opened this Issue May 23, 2018 · 3 comments

Comments

Projects
None yet
2 participants
@klaus3000

klaus3000 commented May 23, 2018

  • Program: Authoritative
  • Issue type: Bug report

Short description

It seems #6328 is incomplete. When the query comes in with TCP and ALIAS expansion is performed, the label in the answer section is the ALIAS target instead of the queried label.

Environment

  • Operating system: Ubuntu 14.04
  • Software version: pdns 4.1.2+8.gdfc00b4-1pdns.trusty
  • Software source: automatic PDNS builds

Steps to reproduce

I query the label master.klaus, which is an ALIAS to myip.pernau.at:

master.klaus. IN ALIAS myip.pernau.at.

$ dig +noall +question +answer @regdev-tst1 master.klaus
;master.klaus.                  IN      A
master.klaus.           30      IN      A       176.9.98.135     --> OK (master.klaus)
$ dig +noall +question +answer @regdev-tst1 master.klaus +tcp
;master.klaus.                  IN      A
myip.pernau.at.         24      IN      A       176.9.98.135    --> WRONG (myip.pernau.at)

Expected behaviour

The left side always should be the queried label, i.e. master.klaus.

Actual behaviour

When queried via TCP, the left side shows the ALIAS target

Other information

Also, the backend-query only uses UDP with EDNS0 and without fallback to TCP on "truncate".

@pieterlexis

This comment has been minimized.

Member

pieterlexis commented May 23, 2018

what backend are you using here?

@klaus3000

This comment has been minimized.

klaus3000 commented May 23, 2018

pdns-backend-pgsql

@pieterlexis

This comment has been minimized.

Member

pieterlexis commented May 23, 2018

Confirmed on master

pieterlexis added a commit to pieterlexis/pdns that referenced this issue May 23, 2018

pieterlexis added a commit to pieterlexis/pdns that referenced this issue May 24, 2018

ALIAS: Ensure correct name in TCP answer
Fixes PowerDNS#6654

(cherry picked from commit 45b037b)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment