Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

when carbon-ourname is set in config, it should not be prefixed with pdns. #6941

Open
miesi opened this issue Sep 7, 2018 · 0 comments

Comments

Projects
None yet
2 participants
@miesi
Copy link

commented Sep 7, 2018

  • Program: Authoritative, Recursor, dnsdist
  • Issue type: Feature change request

Short description

when carbon-ourname is set in config, it should not be prefixed with pdns.

alternatively update documentation https://doc.powerdns.com/authoritative/performance.html: Sending metrics to Graphite/Metronome over Carbon: Warning:

to:

If your hostname includes dots, they will be replaced by underscores so as not to confuse the namespace.

If you include dots in carbon-ourname, they will not be replaced by underscores. As PowerDNS assumes you know what you are doing if you override your hostname. The carbon-ourname be will unconditionally prefixed with pdns.

Expected behaviour

carbon-ourname is not prefixed with anything because it is a setting for people that know what they are doing.

Actual behaviour

metric name is statically nailed down to pdns.. see pdns/auth-carbon.cc line 64

Other information

pdns/auth-carbon.cc line 64 does the unconditional prefix of "pdns."

This is related to #2362.

You could also try a wrap up of all these carbon related issues:

pdns.$hostname.recursor.$metric
1     2        3         4

In my opinion the static strings 1 and 3 need to be configurable.
1 carbon-namespace
2 carbon-ourname
3 carbon-instancename

with the following defaults:
carbon-namespace : "pdns"
carbon-ourname : hostname ~=s,.,_,g
carbon-instancename : config-name

Usecase

I want to consolidate my metrics from collectd and pdns auth,recursor into one namespace.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.