New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rec: Adding NTA doesn't invalidate existing cache #6949

Closed
giganteous opened this Issue Sep 10, 2018 · 1 comment

Comments

Projects
None yet
3 participants
@giganteous
Contributor

giganteous commented Sep 10, 2018

  • Program: Recursor
  • Issue type: Feature request

Short description

Call a cleanup hook when the NTA's change using:

  • rec_control add_nta foo.bar.edu
  • rec_control reload-lua-config

Usecase

Currently I need to know what domains I added to the config when reloading the lua config, or just bluntly call a loop around all my negative anchored domains.

Description

Chat from IRC:

09:16|     kaisan: note, interactions with adding NTA and invalidating existing cache hasn't been optimized it seems.
09:18|     Habbie: ah
09:24|     lieter: we don't clean the cache for that name?
09:24|     Habbie:   broadcastAccFunction<uint64_t>(boost::bind(pleaseWipePacketCache, who, true));
09:24|     Habbie: but no pleaseWipeCache
09:30|     Habbie: also no automatic dnsdist-side cleanup, i suppose
@rgacogne

This comment has been minimized.

Member

rgacogne commented Sep 10, 2018

It looks like we only clear the packet cache but not the record cache when adding or removing (N)TA indeed.

@rgacogne rgacogne added this to the rec-4.1.x milestone Sep 10, 2018

@phonedph1 phonedph1 referenced this issue Sep 10, 2018

Merged

rec: clear all caches on (N)TA changes. #6951

3 of 7 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment