Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
dnsdist: disabled servers return latency as 'null' which breaks webinterface #7461
The dnsdist webinterface breaks when a server is marked as down using
Servers that are marked as down by dnsdist itself do not show this behaviour.
Steps to reproduce
The table should not break when servers are marked as down.
The table breaks when a server is marked as down.
We should either not return the latency value as null from the API, or have the JS properly handle this case. Seeing as no other values are returned as null when a server is marked down, the first solution seems the most elegant.
Specifically, this line probably causes the behaviour : https://github.com/PowerDNS/pdns/blob/master/pdns/dnsdist-web.cc#L565 . I don't agree that hiding the latency for servers that are down is a good idea. If the server has been up, then the latency shown is for when it was responding. Otherwise, we should also null queries, dropRate and sendErrors to be consistent.
Well, it seems misleading to me to send a value that is not updated when the backend is down, see #4689 for example. I do agree it might make sense to do the same for