Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dnsdist: Fails to build with Boost 1.70 (master snapshot) #7556

Closed
jbeich opened this issue Mar 9, 2019 · 2 comments
Closed

dnsdist: Fails to build with Boost 1.70 (master snapshot) #7556

jbeich opened this issue Mar 9, 2019 · 2 comments
Labels
Milestone

Comments

@jbeich
Copy link

@jbeich jbeich commented Mar 9, 2019

Regressed by boostorg/smart_ptr@eac6411. Found on FreeBSD on dnsdist-1.3.3. May not affect other platforms due to header botlegging.

dnsdist-lua-vars.cc:99:61: error: expected unqualified-id
                                       {"BADSIG",   ERCode::BADSIG  },
                                                            ^
/usr/include/sys/signal.h:490:17: note: expanded from macro 'BADSIG'
#define BADSIG          SIG_ERR
                        ^
/usr/include/sys/signal.h:139:18: note: expanded from macro 'SIG_ERR'
#define SIG_ERR         ((__sighandler_t *)-1)
                        ^
1 error generated.
@Habbie
Copy link
Member

@Habbie Habbie commented Mar 9, 2019

botlegging

Can you elaborate on this?

@rgacogne rgacogne added this to the dnsdist-1.3.x milestone Mar 11, 2019
@rgacogne
Copy link
Member

@rgacogne rgacogne commented Mar 11, 2019

I guess we could #undef BADSIG like we already do in dns.hh..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

3 participants