Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--check-config misses misconfigured "webserver" configuration option #8362

Closed
egon1024 opened this issue Sep 30, 2019 · 1 comment · Fixed by #8364
Closed

--check-config misses misconfigured "webserver" configuration option #8362

egon1024 opened this issue Sep 30, 2019 · 1 comment · Fixed by #8364

Comments

@egon1024
Copy link

  • Program: dnsdist
  • Issue type: Bug report

Short description

When running dnsdist (1.3.3-1) with --check-config a specific config error is not caught

Environment

  • Operating system: Ubuntu
  • Software version: Xenial (16.04)
  • Software source: PowerDNS repository

Steps to reproduce

  1. Install dnsdist 1.3.3-1
  2. Add this line to a config file: webserver("127.0.0.6}:1234", "api_password", "api_key")
  3. Run dnsdist with --check-config against the config file and note that it does not report an error (the } between the IP address and the : is invalid, and is reported correctly when starting dnsdist)

Expected behaviour

An error in the configuration to be reported

Actual behaviour

No error is reported

root@ubuntu1604:~# /usr/bin/dnsdist --check-config -C /tmp/tmpdd.conf 
Configuration '/tmp/tmpdd.conf' OK!
@egon1024
Copy link
Author

egon1024 commented Oct 1, 2019

Excellent - thank you @rgacogne :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants