Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dnsdist: Metric for "FrameStreamLogger: queue full, dropping." #8629

Closed
rgacogne opened this issue Dec 13, 2019 · 2 comments · Fixed by #8883
Closed

dnsdist: Metric for "FrameStreamLogger: queue full, dropping." #8629

rgacogne opened this issue Dec 13, 2019 · 2 comments · Fixed by #8883
Labels
dnsdist feature request rec
Milestone
dnsdist-1.4.x

Comments

@rgacogne
Copy link
Member

  • Program: dnsdist
  • Issue type: Feature request

Short description

It would be nice to have a metric for the "FrameStreamLogger: queue full, dropping." case, instead of an error message.
@rgacogne rgacogne added this to the dnsdist-1.4.x milestone Dec 13, 2019
@zeha zeha added the rec label Dec 13, 2019
@zeha
Copy link
Collaborator

zeha commented Dec 13, 2019

Same code is used by the Recursor, so I guess it should also grow a metric for it.

@johnhtodd
Copy link

Yes, please. This is filling up lots of logfiles.

@rgacogne rgacogne mentioned this issue Mar 2, 2020
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dnsdist feature request rec
Projects
None yet
Milestone
dnsdist-1.4.x
Development

Successfully merging a pull request may close this issue.

Add 'queue full' metrics for our remote logger, log at debug only rgacogne/pdns
3 participants
@zeha @rgacogne @johnhtodd