Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dnsdist: in metrics, frontend label has wrong IPv6 formatting #9075

Closed
peterthomassen opened this issue Apr 29, 2020 · 1 comment · Fixed by #9222
Closed

dnsdist: in metrics, frontend label has wrong IPv6 formatting #9075

peterthomassen opened this issue Apr 29, 2020 · 1 comment · Fixed by #9222
Labels
defect dnsdist
Milestone
dnsdist-1.6.0

Comments

@peterthomassen
Copy link
Contributor

peterthomassen commented Apr 29, 2020 •
edited

  • Program: dnsdist
  • Issue type: Bug report

Short description

addLocal("[::]:53") leads to metrics like dnsdist_frontend_queries{frontend=":::53",...}

Environment

  • Operating system: Ubuntu
  • Software version: 1.4.0
  • Software source: PowerDNS repository

Steps to reproduce

trivial

Expected behaviour

dnsdist_frontend_queries{frontend="[::]:53"}

Actual behaviour

see above
@rgacogne
Copy link
Member

I believe we should change this but I'm a bit reluctant to do that now that 1.5.0 reached the release candidate state, I think I'll change that in 1.6.0.

@rgacogne rgacogne added this to the dnsdist-1.6.0 milestone Apr 30, 2020
@supervacuus supervacuus mentioned this issue Jun 11, 2020
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
defect dnsdist
Projects
None yet
Milestone
dnsdist-1.6.0
Development

Successfully merging a pull request may close this issue.

dnsdist: Use toStringWithPort instead of manual addr/port concat supervacuus/pdns
2 participants
@rgacogne @peterthomassen