Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add transport type to logging output (dnstap & pdns protobuf) #9103

Closed
johnhtodd opened this issue May 13, 2020 · 2 comments · Fixed by #10879
Closed

Add transport type to logging output (dnstap & pdns protobuf) #9103

johnhtodd opened this issue May 13, 2020 · 2 comments · Fixed by #10879

Comments

@johnhtodd
Copy link

johnhtodd commented May 13, 2020

  • Program: dnsdist
  • Issue type: Feature request

Short description

Add a field in the dnstap extension that indicates the method of transport by which a packet was delivered to dnsdist.

Usecase

There is nothing in dnstap messages (or pdns protobuf) that describes the delivery method of DNS queries to dnsdist. There are now at least four options:

  • Do53 UDP
  • Do53 TCP
  • DoH (always TCP)
  • DoT (always TCP)
  • DNSCrypt (always UDP...?)
  • (future) DoQUIC?
  • others?

Understanding how a packet was handed to dnsdist is important in debugging performance and behaviors of user communities. This would be digested by upstream dnstap consumers which would then be able to associate specific queries with specific protocol types, or which would be able to aggregate counters to describe behaviors in large quantity over time (TSDB collection/display.)

Description

In a previous ticket (#9102) the concept of putting json-encoded data into the dnstap extension field (https://github.com/dnstap/dnstap.pb/blob/master/dnstap.proto#L40) is mentioned. This might be an obvious next field for inclusion in that fashion.

@rgacogne
Copy link
Member

Moving this to the 1.7.0 milestone but I'd really like to add the missing field in our protocol buffer messages, at the very least, and to find a nice way to encode this into the dnstap extra field.

@rgacogne rgacogne modified the milestones: dnsdist-1.6.0, dnsdist-1.7.0 Jan 19, 2021
@rgacogne
Copy link
Member

Related dnstap/dnstap.pb#13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants