Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typo in prometheus dnsdist_frontend_tlshandshakefailures #9728

Closed
appliedprivacy opened this issue Nov 14, 2020 · 2 comments
Closed

typo in prometheus dnsdist_frontend_tlshandshakefailures #9728

appliedprivacy opened this issue Nov 14, 2020 · 2 comments

Comments

@appliedprivacy
Copy link
Contributor

  • Program: dnsdist
  • Issue type: Bug report

Short description

Typo in prometheus metrics:

is:

dnsdist_frontend_tlshandshakefailures{frontend="0.0.0.0:443",proto="TCP (DNS over HTTPS)",thread="0",error="unsupportedProtocol{"} 3

should be:

dnsdist_frontend_tlshandshakefailures{frontend="0.0.0.0:443",proto="TCP (DNS over HTTPS)",thread="0",error="unsupportedProtocol"} 3

Environment

  • Operating system: FreeBSD
  • Software version: 1.5.1
  • Software source: FreeBSD ports

Steps to reproduce

enable DoH and webserver() and fetch metrics from /metrics

Expected behaviour

should be:

dnsdist_frontend_tlshandshakefailures{frontend="0.0.0.0:443",proto="TCP (DNS over HTTPS)",thread="0",error="unsupportedProtocol"} 3

Actual behaviour

dnsdist_frontend_tlshandshakefailures{frontend="0.0.0.0:443",proto="TCP (DNS over HTTPS)",thread="0",error="unsupportedProtocol{"} 3

Other information

output << frontsbase << "tlshandshakefailures{frontend=\"" << frontName << "\",proto=\"" << proto << "\",thread=\"" << threadNumber << "\",error=\"unsupportedProtocol{\"} " << errorCounters->d_unsupportedProtocol << "\n";

@Habbie
Copy link
Member

Habbie commented Nov 14, 2020

Hello! If you go to the file you already linked, there's an edit button, which makes it easy to create a patch and submit it right in the GitHub webinterface. If you don't feel like it, we'll fix it soon. Thanks!

rgacogne added a commit that referenced this issue Nov 14, 2020
fix a typo in prometheus metrics dnsdist_frontend_tlshandshakefailures #9728
@rgacogne
Copy link
Member

Fixed by #9729.

rgacogne pushed a commit to rgacogne/pdns that referenced this issue Mar 10, 2021
(cherry picked from commit 515b8bb)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants