typo in prometheus dnsdist_frontend_tlshandshakefailures

[appliedprivacy]

• Program: dnsdist
• Issue type: Bug report

Short description

Typo in prometheus metrics:

is:

dnsdist_frontend_tlshandshakefailures{frontend="0.0.0.0:443",proto="TCP (DNS over HTTPS)",thread="0",error="unsupportedProtocol{"} 3

should be:

dnsdist_frontend_tlshandshakefailures{frontend="0.0.0.0:443",proto="TCP (DNS over HTTPS)",thread="0",error="unsupportedProtocol"} 3

Environment

• Operating system: FreeBSD
• Software version: 1.5.1
• Software source: FreeBSD ports

Steps to reproduce

enable DoH and webserver() and fetch metrics from /metrics

Expected behaviour

should be:

dnsdist_frontend_tlshandshakefailures{frontend="0.0.0.0:443",proto="TCP (DNS over HTTPS)",thread="0",error="unsupportedProtocol"} 3

Actual behaviour

dnsdist_frontend_tlshandshakefailures{frontend="0.0.0.0:443",proto="TCP (DNS over HTTPS)",thread="0",error="unsupportedProtocol{"} 3

Other information

pdns/pdns/dnsdist-web.cc

Line 537 in 6eb9e49

output << frontsbase << "tlshandshakefailures{frontend=\"" << frontName << "\",proto=\"" << proto << "\",thread=\"" << threadNumber << "\",error=\"unsupportedProtocol{\"} " << errorCounters->d_unsupportedProtocol << "\n";

[Habbie]

Hello! If you go to the file you already linked, there's an edit button, which makes it easy to create a patch and submit it right in the GitHub webinterface. If you don't feel like it, we'll fix it soon. Thanks!

[rgacogne]

Fixed by #9729.