Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dnsdist: Silence clang 12 warning #10023

Merged
merged 1 commit into from
Jan 27, 2021
Merged

dnsdist: Silence clang 12 warning #10023

merged 1 commit into from
Jan 27, 2021

Conversation

omoerbeek
Copy link
Member

destructor called on non-final 'QPSLimiter' that has virtual functions but non-virtual destructor

Short description

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)

@omoerbeek
Silence clang 12 warning: destructor called on non-final 'QPSLimiter'…
3fc7952 
… that has virtual

functions but non-virtual destructor
@omoerbeek omoerbeek requested a review from rgacogne January 27, 2021 15:24
@omoerbeek omoerbeek enabled auto-merge January 27, 2021 15:30
@omoerbeek omoerbeek merged commit 20a9fbb into PowerDNS:master Jan 27, 2021
@omoerbeek omoerbeek deleted the dnsdist-vdt-BasicQPSLimiter branch February 5, 2021 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rgacogne rgacogne rgacogne approved these changes

Assignees
No one assigned
Labels
dnsdist
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@omoerbeek @rgacogne