Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make NetmaskTree::fork() a bit easier to understand #10046

merged 1 commit into from Feb 4, 2021


Copy link

@rgacogne rgacogne commented Feb 2, 2021

Short description

Coverity reported a leak in that code again after #10035, so I had to read it again and it still confused the heck out of me. I hope these changes will make it a bit more readable, but comments/ideas are welcome!


I have:

  • read the document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code (kinda?)
  • added or modified regression test(s)
  • added or modified unit test(s)

@rgacogne rgacogne merged commit d6e3991 into PowerDNS:master Feb 4, 2021
27 checks passed
@rgacogne rgacogne deleted the doc-nmt-fork branch February 4, 2021 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants