Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dnsdist: Create TCP worker threads before acceptors ones #10088

Merged

Conversation

rgacogne
Copy link
Member

Short description

Otherwise we might crash when the first TCP query arrives because we are dividing by zero when trying to select a worker.
This PR also adds an explicit check to turn the crash into an exception if we ever manage to break that again.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)

Otherwise we might crash when the first TCP query arrives because
we are dividing by zero when trying to select a worker.
@rgacogne
Copy link
Member Author

Unrelated failure in remotebackend-pipe tests, with not much to investigate:

basic-a-resolution
--- ../modules/remotebackend/regression-tests/basic-a-resolution/expected_result	2021-02-16 10:46:16.000000000 +0000
+++ ../modules/remotebackend/regression-tests/basic-a-resolution/real_result	2021-02-16 11:10:45.582292569 +0000
@@ -1,3 +1,2 @@
-0	outpost.example.com.	IN	A	120	192.168.2.1
 Rcode: 0 (No Error), RD: 0, QR: 1, TC: 0, AA: 1, opcode: 0
 Reply to question for qname='outpost.example.com.', qtype=A
./start-test-stop: line 192: kill: (12520) - No such process

Exited with code exit status 1

CircleCI received exit code 1

@Habbie
Copy link
Member

Habbie commented Feb 16, 2021

Unrelated failure in remotebackend-pipe tests, with not much to investigate:

I've seen similar, very seldom, failures in the remotebackend. I haven't found why yet.

@rgacogne rgacogne merged commit 4735f40 into PowerDNS:master Feb 16, 2021
26 of 27 checks passed
@rgacogne rgacogne deleted the ddist-start-tcp-workers-before-acceptors branch February 16, 2021 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants