Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dnsdist: Prevent a crash with DynBPF objects in client mode #10095

Merged
merged 1 commit into from Feb 17, 2021

Conversation

rgacogne
Copy link
Member

Short description

Since we return a nullptr object in client mode, we need to check that the object is valid in all methods and we forgot to do that in addBPFFilterDynBlocks, excludeRange() and includeRange().

Fixes #10090.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)

@rgacogne rgacogne merged commit 748223f into PowerDNS:master Feb 17, 2021
@rgacogne rgacogne deleted the ddist-fix-crash-dbpf-console branch February 17, 2021 10:54
@rgacogne rgacogne mentioned this pull request Mar 10, 2021
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Segmentation fault (core dumped) when running dnsdist client mode and dbpf:excludeRange
2 participants