Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dnsdist: Fix the TCP connect timeout, add metrics #10201

Merged
merged 2 commits into from Mar 24, 2021

Conversation

rgacogne
Copy link
Member

@rgacogne rgacogne commented Mar 19, 2021

Short description

The TCP connect timeout was ignored since 1.4.0, and the write timeout used instead.
Needs more tests(done)

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)

@rgacogne rgacogne added this to the dnsdist-1.6.0 milestone Mar 19, 2021
@rgacogne rgacogne marked this pull request as ready for review March 19, 2021 17:21
@rgacogne
Copy link
Member Author

The failure of the recursor's regression tests is unrelated.

@rgacogne rgacogne merged commit a5ac74b into PowerDNS:master Mar 24, 2021
@rgacogne rgacogne deleted the ddist-connect-timeout branch March 24, 2021 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant