Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dnsdist: Add missing getEDNSOptions and getDO bindings for DNSResponse #10267

Merged
merged 2 commits into from
Apr 8, 2021
Merged

dnsdist: Add missing getEDNSOptions and getDO bindings for DNSResponse #10267

merged 2 commits into from
Apr 8, 2021

Conversation

rgacogne
Copy link
Member

@rgacogne rgacogne commented Apr 6, 2021

Short description

Also document that some methods and attributes are not present on the DNSResponse object.

Fixes #10262.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)

@rgacogne rgacogne added this to the dnsdist-1.6.0 milestone Apr 6, 2021
@rgacogne rgacogne merged commit 9cfe990 into PowerDNS:master Apr 8, 2021
@rgacogne rgacogne deleted the ddist-dr-bindings branch April 8, 2021 07:40
This was referenced May 4, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
defect dnsdist
Projects
None yet
Milestone
dnsdist-1.6.0
Development

Successfully merging this pull request may close these issues.

[dnsdist] method getEDNSOptions on DNSResponse is nil
1 participant
@rgacogne