Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dnsdist: Properly handle ECS for queries with ancount or nscount > 0 #10419

Merged
merged 1 commit into from Jun 2, 2021

Conversation

rgacogne
Copy link
Member

Short description

Some queries (some NOTIFY, for example) have non-empty answer section. Our code handling the addition of EDNS Client Subnet was not properly handling that case when there was no existing EDNS in the query, or more precisely when the additional section was empty.
Closes #10409.
Supersedes #10410.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)

@rgacogne rgacogne merged commit cf6e6c6 into PowerDNS:master Jun 2, 2021
@rgacogne rgacogne deleted the ddist-fix-edns-notify branch June 2, 2021 14:36
@rgacogne rgacogne modified the milestones: dnsdist-1.6.x, dnsdist-1.7.0 Aug 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dnsdist: Error while parsing a NOTIFY query when useClientSubnet=true is set
2 participants