Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dnsdist: Add FFI functions to spoof multiple raw values #10532

Merged
merged 3 commits into from Jun 29, 2021

Conversation

rgacogne
Copy link
Member

Short description

This is the FFI equivalent to DNSQuestion:spoof() 1
I believe this closes #10456.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)

Copy link
Member

@wojas wojas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FFI interface looks good, and so does the implementation as far as I can tell.

@rgacogne rgacogne merged commit 47d57fe into PowerDNS:master Jun 29, 2021
@rgacogne rgacogne deleted the ddist-lua-spoof-multi-raw branch June 29, 2021 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dnsdist: SpoofRaw with comma creates malformed packets
2 participants