dnsdist: Carry the exact incoming protocol (Do53, DNSCrypt, DoT, DoH) in DQ#10537
Merged
rgacogne merged 11 commits intoPowerDNS:masterfrom Jul 7, 2021
Merged
dnsdist: Carry the exact incoming protocol (Do53, DNSCrypt, DoT, DoH) in DQ#10537rgacogne merged 11 commits intoPowerDNS:masterfrom
rgacogne merged 11 commits intoPowerDNS:masterfrom
Conversation
We don't support the exact transport yet.
omoerbeek
approved these changes
Jul 2, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short description
This turned out to be more difficult than I expected. Part of the work already existed in #10338 but was not enough to be able to pass the right protocol to dnstap, which I wanted to do since it now supports DoT and DoH (updated dnstap.proto is included in this PR).
Fixes #10497.
I added the "backport to dnsdist-1.6.x" label because I think we need to fix the dnstap issue on that branch as well, but we clearly should not backport this PR. Perhaps a simple test on whether the request was received over DoH (dq.du is not
nullptr) would be enough for 1.6.x?Checklist
I have: