Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dnsdist: Document that setECSOverride has its drawbacks #10626

Merged
merged 1 commit into from Aug 5, 2021

Conversation

aj-gh
Copy link
Contributor

@aj-gh aj-gh commented Aug 3, 2021

Short description

Document that using setECSOverride in front of Auth servers responding with ECS info can lead to downstream SERVFAIL responses when scopes no longer match and confuse clients (nameservers).

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)
  • checked that this code was merged to master

Copy link
Member

@rgacogne rgacogne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@rgacogne rgacogne merged commit c2b5543 into PowerDNS:master Aug 5, 2021
@aj-gh aj-gh deleted the doc-dnsdist-setecsoverride branch August 10, 2021 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants