convert make_pair to emplace

[neheb]

emplace* forwards the arguments directly. Avoids needing make_pair.

Signed-off-by: Rosen Penev rosenp@gmail.com

Short description

Checklist

I have:

• [x ] read the CONTRIBUTING.md document
• compiled this code
• tested this code
• included documentation (including possible behaviour changes)
• documented the code
• [x ] added or modified regression test(s)
• [x ] added or modified unit test(s)
• checked that this code was merged to master

[neheb]

cool. compiles now.

[neheb]

Fixed.

[omoerbeek]

Sorry for forgetting about this PR. Can you rebase to fix the conflicts?

[neheb]

Rebased. This codebase is a mess. Lots of different styles in use. Maybe clang-format should be looked at.

[Habbie]

We use clang-format except for files mentioned in .not-formatted. It's incremental work, eventually we'll get there - we don't want to break all PRs and backports in one go.

[neheb]

@Habbie just tried it. I assume I should be applying it to this PR?

[Habbie]

'check-formatting - Your tests passed on CircleCI'. You did not break formatting in files we already have formatted, so there's no need for you to do anything here.

[neheb]

'check-formatting - Your tests passed on CircleCI'. You did not break formatting in files we already have formatted, so there's no need for you to do anything here.

hmm? git clang-format HEAD~1 says otherwise.

[Habbie]

hmm? git clang-format HEAD~1 says otherwise.

I doubt that reads .not-formatted.

[omoerbeek]

Reads good. You converted some loops to range loops, but not all. The others can be done some later time,

[rgacogne]

Looks good, just a tiny indentation issue that we could fix later. I'm also wondering why the change to alter the content in two loops?