Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert dnsdist and the recursor to LockGuarded #10649

Merged
merged 32 commits into from Aug 18, 2021
Merged

Convert dnsdist and the recursor to LockGuarded #10649

merged 32 commits into from Aug 18, 2021

Conversation

rgacogne
Copy link
Member

Short description

This PR is a subset of #10302, keeping only the parts related to dnsdist and the recursor, as the ones related to the authoritative server are larger and harder to review.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)

@rgacogne
Introduce LockGuarded, a lock-protected data
92d5b98 
The general idea has been borrowed from Rust's locks: instead of
defining two objects, the one to be protected, T, and the lock, we
define a single LockGuarded<T> object which contains the object.
That provides two big advantages:
- it is immediately clear which data is protected by the lock
- that data simply can't be accessed without holding the lock.
@rgacogne
dnsdist: Move the eBPF filter class to LockGuarded
f0114d6
@rgacogne
Move the remote logger class to LockGuarded
6b4670e
@rgacogne
dnsdist: Move the ring buffers to LockGuarded
ecab77e
@rgacogne
dnsdist: Move the Lua mutex to LockGuarded
fcfffe2
@rgacogne
Add SharedLockGuarded, a read-write lock version of LockGuarded
e82ff2a
@rgacogne
speedtest: Add tests for LockGuarded
b5ee1f2
@rgacogne
dnsdist: Convert DNSCrypt to SharedLockGuarded
6c1813a
@rgacogne
dnsdist: Convert the Packet Cache to SharedLockGuarded
0310790
@rgacogne
dnsdist: Convert DynBPF to LockGuarded
06fa8b3
@rgacogne
dnsdist: Convert the TCP client counts map to LockGuarded
3d31383
@rgacogne
dnsdist: Convert the web server configuration to LockGuarded
e423906
@rgacogne
dnsdist: Convert GnuTLSTicketsKey to SharedLockGuarded
4172902
@rgacogne
dnsdist: Convert ConcurrentConnectionManager to LockGuarded
5b03964
@rgacogne
dnsdist: Convert the dynamic blocks topN to LockGuarded
0183099
@rgacogne
dnsdist: Convert CDBKVStore to SharedLockGuarded
de98618
@rgacogne
Convert the StateHolder to LockGuarded
4a7f983
@rgacogne
dnsdist: Convert most of the remaining locks to LockGuarded
17e1699
@rgacogne
LockGuarded: Add move constructors
b07f6d7
@rgacogne
dnsdist: Convert remaining Action mutexes to LockGuarded
deaea92
@rgacogne
rec: Convert the aggressive NSEC cache to LockGuarded
1f9eeeb
@rgacogne
rec: Convert RPZ loader stats to LockGuarded
0fb64ae
@rgacogne
rec: Move the NOD code to LockGuarded
e837d8d
@rgacogne
Rename the lock() method to write_lock() for shared mutexes
6e41eb9
@rgacogne
rec: Move the record caches to LockGuarded (WIP: size() should not ne…
41fcded 
…ed a lock)
@rgacogne
rec: Convert the dynmetrics to LockGuarded
13bf974
@rgacogne
rec: Store the carbon configuration in a StateHolder
58d7ad6
@rgacogne
dnsdist: Remove unused mutex include
bb4d4f2
@rgacogne
rec: Do not require taking the lock to know the size of a cache
7a83afe
@rgacogne
Document how our wrappers around mutexes work
ffb9243
omoerbeek
omoerbeek approved these changes Aug 18, 2021
View reviewed changes
Copy link
Member

@omoerbeek omoerbeek left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did a read-through of the previous PR without finding any worrying changes. I think it is time to put this in, so it can get some real-life testing.

@rgacogne rgacogne merged commit c28b235 into PowerDNS:master Aug 18, 2021
@rgacogne rgacogne deleted the lock-guarded-ddist branch August 18, 2021 09:31
@rgacogne rgacogne mentioned this pull request Aug 18, 2021
Closed
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@omoerbeek omoerbeek omoerbeek approved these changes

Assignees
No one assigned
Labels
dnsdist enhancement rec
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rgacogne @omoerbeek