Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dnsdist docs: fix example that causes TC=1 on TCP #10693

Closed
wants to merge 1 commit into from

Conversation

Habbie
Copy link
Member

@Habbie Habbie commented Sep 6, 2021

Short description

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)
  • checked that this code was merged to master


This will respectively drop traffic exceeding that 5 QPS limit per IP or range, or return it with TC=1, forcing clients to fall back to TCP.

In that last one, note the use of ``TCPRule``.
Without it clients, would get TC=1 even if they correctly fell back to TCP.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/,//

@rgacogne rgacogne mentioned this pull request Sep 7, 2021
7 tasks
@Habbie
Copy link
Member Author

Habbie commented Sep 7, 2021

Replaced by #10695

@Habbie Habbie closed this Sep 7, 2021
@Habbie Habbie deleted the dnsdist-docs-maxqps-tcp branch September 7, 2021 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants