Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dnsdist-1.6.x: Fix outstanding counter issue #10706

Merged

Conversation

rgacogne
Copy link
Member

@rgacogne rgacogne commented Sep 9, 2021

Short description

When the client closes the TCP connection while we are still waiting for the backend to send at least one response, and the backend connection then terminates abnormally, we could have not properly reset the outstanding
counter of that backend.

Backport of #10705 to rel/dnsdist-1.6.x.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)
  • checked that this code was merged to master

When the client closes the TCP connection while we are still waiting
for the backend to send at least one response, and the backend connection
then terminates anormally, we could have not properly reset the outstanding
counter of that backend.
@rgacogne rgacogne added this to the dnsdist-1.6.x milestone Sep 9, 2021
@rgacogne rgacogne merged commit e01607e into PowerDNS:rel/dnsdist-1.6.x Sep 13, 2021
@rgacogne rgacogne deleted the ddist16-outstanding-tcp branch September 13, 2021 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant