Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dnsdist: Fix the unit tests to handle v4-only or v6-only connectivity #10775

Merged

Conversation

rgacogne
Copy link
Member

Short description

In the load-balancing policies tests, we simply do not try to open a connection to the backend. In the TCP and HTTP/2 tests, we detect which protocol is available by trying to connect a socket, and use v6 if it is available and v4 otherwise.

Closes #10403.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)

@rgacogne rgacogne added this to the dnsdist-1.7.0-alpha2 milestone Sep 29, 2021
@rgacogne rgacogne merged commit 450d07c into PowerDNS:master Oct 13, 2021
@rgacogne rgacogne deleted the ddist-fix-unit-tests-connectivity branch October 13, 2021 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dnsdist test_dnsdisttcp_cc/test_IncomingConnection* not as protocol neutral as maybe expected
1 participant