Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use make_unique instead of new #10870

Merged
merged 1 commit into from
Oct 21, 2021
Merged

use make_unique instead of new #10870

merged 1 commit into from
Oct 21, 2021

Conversation

neheb
Copy link
Contributor

@neheb neheb commented Oct 20, 2021

Signed-off-by: Rosen Penev rosenp@gmail.com

@neheb neheb force-pushed the uniq branch 3 times, most recently from fc5c9bd to e69b600 Compare October 20, 2021 03:17
pdns/dnsdistdist/test-dnsdistkvs_cc.cc Outdated Show resolved Hide resolved
pdns/dnsdistdist/test-dnsdistkvs_cc.cc Outdated Show resolved Hide resolved
Signed-off-by: Rosen Penev <rosenp@gmail.com>
Copy link
Member

@omoerbeek omoerbeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks for the work on modernizing this (partly 20 years) old codebase.
As for workflow; in general I like a push and not a force push for PR revisions. After the force push I had to look though the complete PR again to make sure nothing bad crept in. A regular commit would have shown me just what changed compared to review I did earlier.

@rgacogne rgacogne merged commit 4e0bdea into PowerDNS:master Oct 21, 2021
@neheb neheb deleted the uniq branch October 21, 2021 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants