Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dnsdist: Properly handle I/O exceptions in the health checker #10874

Merged
merged 2 commits into from
Oct 25, 2021

Conversation

rgacogne
Copy link
Member

Short description

This prevented the backend from being marked down on some failures.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)

Copy link
Member

@omoerbeek omoerbeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Related: comment on line 88 reads wrong

@rgacogne rgacogne merged commit cadde68 into PowerDNS:master Oct 25, 2021
@rgacogne rgacogne deleted the ddist-fix-healthcheck-exception branch October 25, 2021 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants