Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dnsdist: Stop over-allocating for DoH queries #10876

Merged
merged 1 commit into from Oct 29, 2021

Conversation

rgacogne
Copy link
Member

Short description

It used to be necessary because we had a fixed buffer and might have needed the space for cache hits, but nowadays we can resize later if needed so stop wasting memory.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)

It used to be necessary because we had a fixed buffer and might have
needed the space for cache hits, but nowadays we can resize later
if needed so stop wasting memory.
@rgacogne rgacogne merged commit 1e91019 into PowerDNS:master Oct 29, 2021
@rgacogne rgacogne deleted the ddist-doh-memory branch October 29, 2021 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants