Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dnsdist: Handle existing EDNS content for SetMacAddrAction/SetEDNSOptionAction #10907

Merged
merged 2 commits into from
Nov 15, 2021
Merged

dnsdist: Handle existing EDNS content for SetMacAddrAction/SetEDNSOptionAction #10907

merged 2 commits into from
Nov 15, 2021

Conversation

rgacogne
Copy link
Member

Short description

Closes #4670.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)

@rgacogne rgacogne added this to the dnsdist-1.7.0-alpha3 milestone Oct 27, 2021
omoerbeek
omoerbeek reviewed Oct 29, 2021
View reviewed changes
pdns/dnsdist-ecs.cc Outdated Show resolved Hide resolved
pdns/dnsdist-ecs.cc Outdated Show resolved Hide resolved
@rgacogne rgacogne merged commit 4595742 into PowerDNS:master Nov 15, 2021
@rgacogne rgacogne deleted the ddist-handle-existing-edns-mac-setedns branch November 15, 2021 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chbruyand chbruyand Awaiting requested review from chbruyand

@omoerbeek omoerbeek Awaiting requested review from omoerbeek

Assignees
No one assigned
Labels
dnsdist enhancement
Projects
None yet
Milestone
dnsdist-1.7.0-beta1
Development

Successfully merging this pull request may close these issues.

dnsdist: MacAddrAction() should handle EDNS-enabled queries
2 participants
@rgacogne @omoerbeek