Skip to content

dnsdist: Add a Lua FFI helper to generate proxy protocol payloads #10949

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 16, 2021
Merged

dnsdist: Add a Lua FFI helper to generate proxy protocol payloads #10949

merged 2 commits into from
Dec 16, 2021

Conversation

rgacogne
Copy link
Member

@rgacogne rgacogne commented Nov 5, 2021

Short description

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)

@rgacogne rgacogne added this to the dnsdist-1.8.0 milestone Nov 5, 2021
@rgacogne rgacogne force-pushed the ddist-lua-ffi-proxy-protocol branch from 7365f8d to a64c238 Compare December 15, 2021 14:11
@rgacogne
Copy link
Member Author

Rebased to fix a conflict.

@rgacogne rgacogne requested a review from chbruyand December 15, 2021 14:11
chbruyand
chbruyand approved these changes Dec 15, 2021
View reviewed changes
Copy link
Member

@chbruyand chbruyand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rgacogne
Copy link
Member Author

Build failure is unrelated.

@rgacogne rgacogne merged commit 4169f78 into PowerDNS:master Dec 16, 2021
@rgacogne rgacogne deleted the ddist-lua-ffi-proxy-protocol branch December 16, 2021 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chbruyand chbruyand chbruyand approved these changes

Assignees
No one assigned
Labels
dnsdist enhancement
Projects
None yet
Milestone
dnsdist-1.8.0
Development

Successfully merging this pull request may close these issues.
2 participants
@rgacogne @chbruyand