Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dnsdist: Add 'showWebserverConfig' #11006

Merged
merged 2 commits into from
Nov 24, 2021
Merged

dnsdist: Add 'showWebserverConfig' #11006

merged 2 commits into from
Nov 24, 2021

Conversation

rgacogne
Copy link
Member

Short description

Closes #10135.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)

@rgacogne rgacogne added this to the dnsdist-1.7.0-beta2 milestone Nov 18, 2021
chbruyand
chbruyand approved these changes Nov 23, 2021
View reviewed changes
Copy link
Member

@chbruyand chbruyand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A little cosmetic suggestion, but LGTM anyway!

pdns/dnsdist-web.cc Outdated Show resolved Hide resolved
pdns/dnsdist-web.cc Show resolved Hide resolved
pdns/dnsdist-web.cc Outdated Show resolved Hide resolved
pdns/dnsdist-lua.cc Outdated Show resolved Hide resolved
@rgacogne rgacogne merged commit 812645f into PowerDNS:master Nov 24, 2021
@rgacogne rgacogne deleted the ddist-show-web-config branch November 24, 2021 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chbruyand chbruyand chbruyand approved these changes

Assignees
No one assigned
Labels
dnsdist enhancement
Projects
None yet
Milestone
dnsdist-1.7.0-beta2
Development

Successfully merging this pull request may close these issues.

Ability to show current webServer configuration
2 participants
@rgacogne @chbruyand