-
Notifications
You must be signed in to change notification settings - Fork 917
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dnsdist: add support for password protected PCKS12 files for TLS configuration #11027
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good! A regression test creating a password-protected PKCS12 file in runtests
then loading it in test_DOH
and/or test_TLS
would be nice :)
Test failures are unrelated:
|
Eww, using the GH editor to fix a conflict in the documentation resulted in a big merge commit. @chbruyand Shall I rebase your branch on master instead? |
7a2754c
to
afdad06
Compare
Rebased to fix conflict |
Short description
This adds support for password protected PCKS12 files.
addDOHLocal
andaddTLSLocal
now accept either a singlecert
parameter (without anykey
) and thus try to open it as a PCKS12 file or directly aTLSCertificate
object initialized vianewTLSCertificate
.Checklist
I have: