Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dnsdist: Reuse and save the TLS session tickets in DoT healthchecks #11037

Merged

Conversation

rgacogne
Copy link
Member

Short description

This reduces the cost of the healthchecks themselves while saving the TLS session reduces the cost of opening of a DoT connection for actual queries later on.
In the future a refactoring of the TCP/DoT healthcheck code to be more like the "black box" approach used for DoH would be nice to have.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)

This reduces the cost of the healthchecks themselves while saving the
TLS session reduces the cost of opening of a DoT connection for actual
queries later on.
In the future a refactoring of the TCP/DoT healthcheck code to be more
like the "black box" approach used for DoH would be nice to have.
Copy link
Member

@omoerbeek omoerbeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one nit

pdns/dnsdistdist/dnsdist-healthchecks.cc Outdated Show resolved Hide resolved
@rgacogne rgacogne merged commit 15de0e0 into PowerDNS:master Nov 26, 2021
@rgacogne rgacogne deleted the ddist-healthcheck-reuse-tls-session branch November 26, 2021 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants