Skip to content

dnsdist: add lua support to limit TTL values of responses #11059

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 14, 2021

Conversation

chbruyand
Copy link
Member

Short description

This adds LimitTTLResponseAction(), SetMinTTLResponseAction() and SetMaxTTLResponseAction() to limit returned TTL values to given boundaries.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)

Copy link
Member

@rgacogne rgacogne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! I think we need a few changes to keep the Lua FFI version fast, but nothing too complicated I hope.

@chbruyand chbruyand marked this pull request as draft December 3, 2021 17:03
@chbruyand chbruyand marked this pull request as ready for review December 3, 2021 18:08
Co-authored-by: Remi Gacogne <github@coredump.fr>
@chbruyand chbruyand force-pushed the dnsdist-lua-ttl-limit branch from 392a1b1 to bb5f0d6 Compare December 6, 2021 11:51
@chbruyand chbruyand merged commit 4d44118 into PowerDNS:master Dec 14, 2021
@chbruyand chbruyand deleted the dnsdist-lua-ttl-limit branch January 19, 2024 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants