Skip to content

dnsdist: Add Lua FFI helpers for protocol and MAC address access, proxy protocol payload generation #11173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 1, 2022

Conversation

rgacogne
Copy link
Member

Short description

This PR could use unit and regression tests.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)

@rgacogne
Copy link
Member Author

Check if we want to use the new getMacAddress API introduced in #11184 before merging this.

@rgacogne rgacogne force-pushed the ddist-proxy-proto-ffi branch from eac05fa to 3d5b87e Compare January 14, 2022 09:29
@rgacogne
Copy link
Member Author

Check if we want to use the new getMacAddress API introduced in #11184 before merging this.

Done (as suggested by @chbruyand, thanks!).

@rgacogne
Copy link
Member Author

rgacogne commented Feb 1, 2022

I have written unit tests for that PR on a different branch, I'll open a new PR later.

@rgacogne rgacogne merged commit a29275a into PowerDNS:master Feb 1, 2022
@rgacogne rgacogne deleted the ddist-proxy-proto-ffi branch February 1, 2022 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant