Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dnsdist: add support to store mac address in query rings #11184

Merged
merged 1 commit into from
Jan 14, 2022

Conversation

chbruyand
Copy link
Member

Short description

This PR adds support for storing mac address of the requestor in query rings (only when compiled with -DDNSDIST_RINGS_WITH_MACADDRESS).

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)

Copy link
Member

@rgacogne rgacogne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks! I agree it doesn't make sense to have this compiled in by default, wasting memory as it should be useful in some particular setups.

@rgacogne rgacogne merged commit d7c28d1 into PowerDNS:master Jan 14, 2022
@chbruyand chbruyand deleted the dnsdist-mac-ring-buffers branch January 19, 2024 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants