Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dnsdist: Fix the latency-count metric #11323

Merged
merged 2 commits into from
Feb 22, 2022
Merged

dnsdist: Fix the latency-count metric #11323

merged 2 commits into from
Feb 22, 2022

Conversation

rgacogne
Copy link
Member

Short description

Fixes #11239.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)

@rgacogne rgacogne added this to the dnsdist-1.8.0 milestone Feb 14, 2022
omoerbeek
omoerbeek approved these changes Feb 22, 2022
View reviewed changes
Copy link
Member

@omoerbeek omoerbeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I push a commit improving the docs a little. From the existing description of latency-bucket I could not infer what it actually was.

@rgacogne rgacogne merged commit 9161697 into PowerDNS:master Feb 22, 2022
@rgacogne rgacogne deleted the ddist-latency-count branch February 22, 2022 08:24
@rgacogne rgacogne mentioned this pull request Apr 20, 2022
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@omoerbeek omoerbeek omoerbeek approved these changes

Assignees
No one assigned
Labels
defect dnsdist
Projects
None yet
Milestone
dnsdist-1.8.0
Development

Successfully merging this pull request may close these issues.

dnsdist: latency-count is broken
2 participants
@rgacogne @omoerbeek