dnsdist: Only allocate the health-check mplexer when needed #11437
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
When health-checking is disabled, or when a check delay longer than one second is used, there is no need to allocate a new multiplexer object every second.
The CPU gain here is not huge, but it might matter for low-end devices, as mentioned in #11422. Since most of the CPU usage here seems to be caused by our handling of UDP timeouts, where we scan
setMaxUDPOutstanding
1 buckets every second, a much better improvement for these low-end devices can be reached on master by settingsetRandomizedIdsOverUDP(true)
2, allowing us to only scan the buckets that are actually in use.Checklist
I have: