Skip to content

dnsdist: Add setTCPFastOpenKey() #11497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Apr 5, 2022
Merged

dnsdist: Add setTCPFastOpenKey() #11497

merged 6 commits into from
Apr 5, 2022

Conversation

Y7n05h
Copy link
Contributor

@Y7n05h Y7n05h commented Apr 3, 2022 •
edited
Loading

Signed-off-by: Y7n05h Y7n05h@protonmail.com

Short description

Partially implemented #9994

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)
  • checked that this code was merged to master

@Y7n05h
dnsdist: Add setTCPFastOpenKey()
be5e1fc 
Signed-off-by: Y7n05h <Y7n05h@protonmail.com>
omoerbeek
omoerbeek reviewed Apr 3, 2022
View reviewed changes
@Y7n05h
Add conditional compilation
e81ca57 
Signed-off-by: Y7n05h <Y7n05h@protonmail.com>
@Y7n05h Y7n05h requested a review from omoerbeek April 3, 2022 15:04
@rgacogne rgacogne self-requested a review April 4, 2022 09:34
rgacogne
rgacogne requested changes Apr 4, 2022
View reviewed changes
Copy link
Member

@rgacogne rgacogne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! The code looks good, I suggested a small change but nothing big. Do you think you could add a few lines of documentation in docs/reference/config.rst, likely at the end of the Other functions section?

Y7n05h added 2 commits April 4, 2022 19:43
@Y7n05h
dnsdist: Change the type of g_TCPFastOpenKey and related variables
caaa8db 
Signed-off-by: Y7n05h <Y7n05h@protonmail.com>
@Y7n05h
dnsdist: add document for setTCPFastOpenKey()
e21a027 
Signed-off-by: Y7n05h <Y7n05h@protonmail.com>
@Y7n05h Y7n05h requested a review from rgacogne April 4, 2022 11:49
rgacogne
rgacogne reviewed Apr 4, 2022
View reviewed changes
Y7n05h and others added 2 commits April 4, 2022 21:41
@Y7n05h @rgacogne
Update pdns/dnsdist-lua.cc
4b0c0aa 
Co-authored-by: Remi Gacogne <github@coredump.fr>
@Y7n05h @rgacogne
Update pdns/dnsdistdist/docs/reference/config.rst
28dc6ce 
Co-authored-by: Remi Gacogne <github@coredump.fr>
@rgacogne rgacogne added this to the dnsdist-1.8.0 milestone Apr 4, 2022
rgacogne
rgacogne approved these changes Apr 5, 2022
View reviewed changes
Copy link
Member

@rgacogne rgacogne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very good to me, thanks a lot!

@rgacogne rgacogne merged commit a98f2f5 into PowerDNS:master Apr 5, 2022
@rgacogne rgacogne mentioned this pull request Apr 14, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rgacogne rgacogne rgacogne approved these changes

@omoerbeek omoerbeek Awaiting requested review from omoerbeek

Assignees
No one assigned
Labels
dnsdist enhancement
Projects
None yet
Milestone
dnsdist-1.8.0
Development

Successfully merging this pull request may close these issues.
3 participants
@Y7n05h @rgacogne @omoerbeek