Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reject BPFFilter::attachToAllBinds() at configuration time #11523

Merged
merged 2 commits into from
Apr 12, 2022

Conversation

Y7n05h
Copy link
Contributor

@Y7n05h Y7n05h commented Apr 11, 2022

Signed-off-by: Y7n05h Y7n05h@protonmail.com

Short description

Allowing the use of BPFFilter::attachToAllBinds() at configuration time will result in ambiguous semantics.
In fact, using BPFFilter::attachToAllBinds() at configuration may not take effect.
Reject the use of BPFFilter::attachToAllBinds() at configuration time will prevent misuse.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)
  • checked that this code was merged to master

Signed-off-by: Y7n05h <Y7n05h@protonmail.com>
Copy link
Member

@rgacogne rgacogne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot, much appreciated!

pdns/dnsdistdist/docs/reference/ebpf.rst Outdated Show resolved Hide resolved
Co-authored-by: Remi Gacogne <github@coredump.fr>
@rgacogne
Copy link
Member

CI failures are unrelated.

@rgacogne rgacogne merged commit 17aa2f6 into PowerDNS:master Apr 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants