Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge multiple parameters in newBPFFilter #11535

Merged
merged 10 commits into from
Apr 15, 2022
Merged

Merge multiple parameters in newBPFFilter #11535

merged 10 commits into from
Apr 15, 2022

Conversation

Y7n05h
Copy link
Contributor

@Y7n05h Y7n05h commented Apr 13, 2022 •
edited
Loading

Signed-off-by: Y7n05h Y7n05h@protonmail.com

Short description

As discussed in #11526.
It is necessary to combine the parameters in newBPFFilter into a table.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)
  • checked that this code was merged to master

cmouse
cmouse suggested changes Apr 13, 2022
View reviewed changes
pdns/bpf-filter.cc Outdated Show resolved Hide resolved
pdns/bpf-filter.cc Outdated Show resolved Hide resolved
pdns/bpf-filter.cc Outdated Show resolved Hide resolved
pdns/dnsdist-lua-bindings.cc Outdated Show resolved Hide resolved
pdns/dnsdist-lua-bindings.cc Outdated Show resolved Hide resolved
pdns/dnsdist-lua-bindings.cc Outdated Show resolved Hide resolved
@Y7n05h Y7n05h force-pushed the MergeParams branch 4 times, most recently from 1784375 to eecf9dd Compare April 14, 2022 00:04
@Y7n05h
Merge multiple parameters in newBPFFilter
411dccd 
Signed-off-by: Y7n05h <Y7n05h@protonmail.com>
rgacogne
rgacogne reviewed Apr 14, 2022
View reviewed changes
pdns/dnsdist-lua-bindings.cc Outdated Show resolved Hide resolved
pdns/dnsdist-lua-bindings.cc Outdated Show resolved Hide resolved
pdns/dnsdist-lua-bindings.cc Outdated Show resolved Hide resolved
pdns/dnsdistdist/docs/reference/ebpf.rst Outdated Show resolved Hide resolved
pdns/dnsdistdist/docs/reference/ebpf.rst Outdated Show resolved Hide resolved
Y7n05h and others added 2 commits April 14, 2022 19:10
@Y7n05h @rgacogne
Update pdns/dnsdist-lua-bindings.cc
72a0f73 
Co-authored-by: Remi Gacogne <github@coredump.fr>
@Y7n05h @rgacogne
Update pdns/dnsdistdist/docs/reference/ebpf.rst
3c2e56c 
Co-authored-by: Remi Gacogne <github@coredump.fr>
@Y7n05h Y7n05h requested a review from rgacogne April 14, 2022 12:42
rgacogne
rgacogne reviewed Apr 14, 2022
View reviewed changes
Copy link
Member

@rgacogne rgacogne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks great, thanks! A few nits on the documentation but nothing big.

pdns/dnsdistdist/docs/reference/ebpf.rst Show resolved Hide resolved
pdns/dnsdistdist/docs/reference/ebpf.rst Outdated Show resolved Hide resolved
Y7n05h and others added 2 commits April 14, 2022 23:25
@Y7n05h @rgacogne
Update pdns/dnsdistdist/docs/reference/ebpf.rst
4bc9622 
Co-authored-by: Remi Gacogne <github@coredump.fr>
@Y7n05h @rgacogne
Update pdns/dnsdistdist/docs/reference/ebpf.rst
a2514b5 
Co-authored-by: Remi Gacogne <github@coredump.fr>
rgacogne
rgacogne approved these changes Apr 14, 2022
View reviewed changes
Copy link
Member

@rgacogne rgacogne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, I'll merge this PR once our CI is green!

@rgacogne rgacogne added this to the dnsdist-1.8.0 milestone Apr 14, 2022
@Y7n05h
Copy link
Contributor Author

Y7n05h commented Apr 14, 2022 •
edited
Loading

Thank you @cmouse and @rgacogne for your careful and rigorous Code Review. my many oversights have added a lot of work for you. I will pay attention to improve the quality of code and documentation later.

rgacogne
rgacogne approved these changes Apr 15, 2022
View reviewed changes
Copy link
Member

@rgacogne rgacogne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, thanks!

pdns/dnsdistdist/docs/reference/ebpf.rst Outdated Show resolved Hide resolved
@rgacogne rgacogne merged commit 76b62b1 into PowerDNS:master Apr 15, 2022
@Y7n05h Y7n05h deleted the MergeParams branch April 22, 2022 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmouse cmouse cmouse requested changes

@rgacogne rgacogne rgacogne approved these changes

Assignees
No one assigned
Labels
dnsdist enhancement
Projects
None yet
Milestone
dnsdist-1.8.0
Development

Successfully merging this pull request may close these issues.
3 participants
@Y7n05h @rgacogne @cmouse