dnsdist: Log when a console message exceeds the maximum size #11543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise one cannot know whether the server has closed the connection or sent a too large message.
I don't see any case where that could happen but better wrap the socket descriptors in FDWrapper objects so that we cannot forget to close them if an exception is raised, for example.
omoerbeek
approved these changes
Apr 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
Otherwise one cannot know whether the server has closed the connection or sent a too large message.
Also wrap the console's socket descriptors in FDWrapper objects to make sure we do not forget to close them in the future, doing that manually is always brittle.
Closes #11488
Checklist
I have: