Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dnsdist: Use the correct outgoing protocol in our ring buffers #11545

Merged
merged 1 commit into from
Apr 21, 2022

Conversation

rgacogne
Copy link
Member

Short description

Should fix #11501.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)

@rgacogne
Copy link
Member Author

CI failure is unrelated (auth test that seems flappy?):

  ..............Apr 15 10:51:37 gsqlite3: connection to 'configs/auth/powerdns.sqlite' successful
  Apr 15 10:51:37 gsqlite3: connection to 'configs/auth/powerdns.sqlite' successful
  Apr 15 10:51:37 [bindbackend] Parsing 0 domain(s), will report when done
  Apr 15 10:51:37 [bindbackend] Done parsing domains, 0 rejected, 0 new, 0 removed
  Creating secondary zone 'example', with primaries '127.0.0.1:4244'
  Apr 15 10:51:37 No serial for 'example' found - zone is missing?
  Apr 15 10:51:37 gsqlite3: connection to 'configs/auth/powerdns.sqlite' successful
  Apr 15 10:51:37 gsqlite3: connection to 'configs/auth/powerdns.sqlite' successful
  Apr 15 10:51:37 [bindbackend] Parsing 0 domain(s), will report when done
  Apr 15 10:51:37 [bindbackend] Done parsing domains, 0 rejected, 0 new, 0 removed
  Apr 15 10:51:37 No serial for 'example' found - zone is missing?
  Set 'example' meta IXFR = 1
  .............................................Apr 15 10:52:28 gsqlite3: connection to 'configs/auth/powerdns.sqlite' successful
  Apr 15 10:52:28 gsqlite3: connection to 'configs/auth/powerdns.sqlite' successful
  Apr 15 10:52:28 [bindbackend] Parsing 1 domain(s), will report when done
  Apr 15 10:52:28 [bindbackend] parsing 'example.org' from file 'configs/auth/example.org.zone'
  Apr 15 10:52:28 [bindbackend] Done parsing domains, 0 rejected, 1 new, 0 removed
  Creating secondary zone 'zone.rpz', with primaries '127.0.0.1:4251'
  Apr 15 10:52:28 No serial for 'zone.rpz' found - zone is missing?
  Apr 15 10:52:28 gsqlite3: connection to 'configs/auth/powerdns.sqlite' successful
  Apr 15 10:52:28 gsqlite3: connection to 'configs/auth/powerdns.sqlite' successful
  Apr 15 10:52:28 [bindbackend] Parsing 1 domain(s), will report when done
  Apr 15 10:52:28 [bindbackend] parsing 'example.org' from file 'configs/auth/example.org.zone'
  Apr 15 10:52:28 [bindbackend] Done parsing domains, 0 rejected, 1 new, 0 removed
  Apr 15 10:52:28 No serial for 'zone.rpz' found - zone is missing?
  Set 'zone.rpz' meta IXFR = 1
  Added retrieval request for 'zone.rpz' from primary 127.0.0.1:4251
  Added retrieval request for 'zone.rpz' from primary 127.0.0.1:4251
  F
  ======================================================================
  FAIL: testXFR (test_XFRIncomplete.XFRIncompleteAuthTest)
  ----------------------------------------------------------------------
  Traceback (most recent call last):
    File "/home/runner/work/pdns/pdns/regression-tests.auth-py/test_XFRIncomplete.py", line 191, in testXFR
      self.waitUntilCorrectSerialIsLoaded(2)
    File "/home/runner/work/pdns/pdns/regression-tests.auth-py/test_XFRIncomplete.py", line 170, in waitUntilCorrectSerialIsLoaded
      raise AssertionError("Waited %d seconds for the serial to be updated to %d but the serial is still %d" % (timeout, serial, currentSerial))
  AssertionError: Waited 5 seconds for the serial to be updated to 2 but the serial is still 1
  
  ----------------------------------------------------------------------

Copy link
Member

@chbruyand chbruyand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rgacogne rgacogne merged commit c6e732a into PowerDNS:master Apr 21, 2022
@rgacogne rgacogne deleted the ddist-fix-backend-proto branch April 21, 2022 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dnsdist: downstream response protocol can be confusing
2 participants