Skip to content

dnsdist-1.7.x: Properly use eBPF when the DynBlock is not set #11550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

rgacogne
Copy link
Member

@rgacogne rgacogne commented Apr 15, 2022

Short description

When the DynBlock rule does not set a specific action we use the default one, set with setDynBlocksAction(), so we should follow the same logic when determining whether to insert an eBPF block.

(cherry picked from commit 8742251)

Backport of #11544 to rel/dnsdist-1.7.x.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)
  • checked that this code was merged to master

When the DynBlock rule does not set a specific action we use the
default one, set with `setDynBlocksAction()`, so we should follow
the same logic when determining whether to insert an eBPF block.

(cherry picked from commit 8742251)
@rgacogne rgacogne force-pushed the ddist17-bpf-block-action branch from 534a1a7 to dcddd2f Compare April 15, 2022 14:25
@rgacogne
Copy link
Member Author

Rebased to fix the jinja2 failure.

@rgacogne rgacogne merged commit d488b26 into PowerDNS:rel/dnsdist-1.7.x Apr 22, 2022
@rgacogne rgacogne deleted the ddist17-bpf-block-action branch April 22, 2022 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants