Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dnsdist: Add setVerbose() to switch the verbose mode at runtime #11567

Merged
merged 2 commits into from
May 3, 2022

Conversation

rgacogne
Copy link
Member

Short description

And also from the configuration, without having to edit the arguments passed to the program.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)

And also from the configuration, without having to edit the arguments
passed to the program.
@rgacogne
Copy link
Member Author

CI failure is unrelated:

   FAIL: testA (test_SimpleForwardOverDoT.testSimpleForwardOverDoT)
  ----------------------------------------------------------------------
  Traceback (most recent call last):
    File "/home/runner/work/pdns/pdns/regression-tests.recursor-dnssec/test_SimpleForwardOverDoT.py", line 36, in testA
      self.assertMessageIsAuthenticated(res)
    File "/home/runner/work/pdns/pdns/regression-tests.recursor-dnssec/recursortests.py", line 856, in assertMessageIsAuthenticated
      self.assertTrue('AD' in msgFlags, "No AD flag found in the message for %s" % msg.question[0].name)
  AssertionError: False is not true : No AD flag found in the message for dns.google.
  
  ----------------------------------------------------------------------

Co-authored-by: Charles-Henri Bruyand <charleshenri.bruyand+github@gmail.com>
@rgacogne rgacogne requested a review from chbruyand April 29, 2022 06:13
@rgacogne rgacogne merged commit f4f69b4 into PowerDNS:master May 3, 2022
@rgacogne rgacogne deleted the ddist-set-verbose branch May 3, 2022 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants