dnsdist: Add 'statistics' to the general API endpoint #11659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rgacogne
force-pushed
the
ddist-add-stats-to-general-api-endpoint
branch
from
4663ae5 to
44b750c
Compare
Habbie
approved these changes
Jun 7, 2022
Making it possible to retrieve all metrics by querying one endpoint (/api/v1/servers/localhost) instead of two (/api/v1/servers/localhost and /api/v1/servers/localhost/statistics).
rgacogne
force-pushed
the
ddist-add-stats-to-general-api-endpoint
branch
from
44b750c to
1432515
Compare
|
I had to rebase the PR to fix a conflict. |
|
The CI failure is unrelated:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
Making it possible to retrieve all metrics by querying one endpoint (
/api/v1/servers/localhost) instead of two (/api/v1/servers/localhostand/api/v1/servers/localhost/statistics).Checklist
I have: